Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use committedDate for ChangeCommitForcePushedEvent's created_at field #1076

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Use committedDate for ChangeCommitForcePushedEvent's created_at field #1076

merged 1 commit into from
Oct 31, 2023

Conversation

morucci
Copy link
Collaborator

@morucci morucci commented Oct 31, 2023

Also this change uses committedDate for ChangeCommitPushedEvent's created_at instead of pushedDate which is deprecated.

fix #1074

@morucci
Use committedDate for ChangeCommitForcePushedEvent's created_at f…
cdef28e 
…ield

Also this change uses `committedDate` for `ChangeCommitPushedEvent`'s
`created_at` instead of `pushedDate` which is deprecated.

fix change-metrics#1074
@leonid-deriv
Copy link

leonid-deriv commented Oct 31, 2023 •
edited
Loading

so both ChangeCommittedPushedEvent and ChangeCommitForcePushedEvent are covered?
Ignore the question - I have looked at the code

@morucci morucci added the merge me Trigger the merge process label Oct 31, 2023
@mergify mergify bot merged commit 8e7fb0c into change-metrics:master Oct 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristanCacqueray TristanCacqueray TristanCacqueray approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect commit time in ChangeCommitPushedEvent
3 participants
@morucci @leonid-deriv @TristanCacqueray